Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch NL from v1beta1 to v1. Fixes #2747. #2798

Merged
merged 2 commits into from
Dec 3, 2016
Merged

Switch NL from v1beta1 to v1. Fixes #2747. #2798

merged 2 commits into from
Dec 3, 2016

Conversation

jmdobry
Copy link
Contributor

@jmdobry jmdobry commented Dec 2, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2016
dhermes
dhermes approved these changes Dec 2, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was easy! Thanks a lot

language/google/cloud/language/document.py
api_response = self.client._connection.api_request(
method='POST', path='analyzeSyntax', data=data)
return [Token.from_api_repr(token)
for token in api_response['tokens']]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

language/unit_tests/test_document.py
'proper': 'PROPER',
'reciprocity': 'RECIPROCITY_UNKNOWN',
'tense': 'TENSE_UNKNOWN',
'voice': 'VOICE_UNKNOWN',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Dec 3, 2016

LGTM

@dhermes dhermes merged commit a02ac50 into googleapis:master Dec 3, 2016
@jmdobry jmdobry deleted the language-v1 branch December 3, 2016 03:14
@jmdobry
Copy link
Contributor Author

jmdobry commented Dec 5, 2016

Is there a set release schedule? What's the ETA on getting a new version of google-cloud-language published?

@dhermes
Copy link
Contributor

dhermes commented Dec 5, 2016

I'll be releasing this afternoon, thanks for checking in

@dhermes dhermes mentioned this pull request Dec 5, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#2798 from jmdobry/language-v1
21e0d30 
Switch NL from v1beta1 to v1. Fixes googleapis#2747.
parthea pushed a commit that referenced this pull request Jul 6, 2023
@dhermes
Merge pull request #2798 from jmdobry/language-v1
48c75b1 
Switch NL from v1beta1 to v1. Fixes #2747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmdobry @tseaver @dhermes @googlebot